dterrahe / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
2 stars 0 forks source link

NG Input: Preferences/Shortcuts no longer has a search facility #12

Closed elstoc closed 3 years ago

elstoc commented 3 years ago

This needs to be reinstated.

Ref: darktable-org#8078

dterrahe commented 3 years ago

How do you mean "reinstated"? Its a completely new dialog 😄

But... it does have a search facility. Its implemented via the "standard" gtk incremental search functionality. Make sure the desired list is active and start typing. It will select the highest level of the tree that contains the string; to get to a particular instance, press the down and up keys.

This is the same functionality that is partially implemented in the presets tab of the preference dialog. Except there, it only seems to work if you type the start of the preset name (it doesn't search module names; fair enough, they are easy to find at top level) but it only finds presets for modules that are expanded. In the shortcuts dialog it will expand the tree if needed to show the matching items (but it will first select the top level containing it, until you press the down button to cycle, which can be useful to know where you are)

elstoc commented 3 years ago

Yes this is why I wrote a proper search for the shortcuts dialog - because the gtk one sucks.

dterrahe commented 3 years ago

But mine is a lot better than the presets one...

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

dterrahe commented 3 years ago

incremental search using standard gtk framework improved so that it expands the tree and shows the exact lines that match the text typed so far. Arrow down/up goes to next/previous match.

I should really implement this for the presets treeview as well...