search

dterrahe / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
2 stars 0 forks source link

FR separate treeview in prefs #15

Closed AlicVB closed 1 year ago

AlicVB commented 3 years ago

in the pref dialog, I find the 2 treeview quite small, considering the amount of data to show, I wonder if it wouldn't be better to add them in different tabs (yes, a tab inside tabs :( like "by shortcuts" and "by actions". But again, maybe I'm overlooking some features here :)

dterrahe commented 3 years ago

Hm. Maybe. I find it convenient that when assigning a bunch of shortcuts to actions in the same section (module, lib) you see them pop up in the other half of the dialog with other "nearby" shortcuts (i.e. same key but different modifier or combined with move or whatever) so you can make further changes there (or you might want to adjust the speed or instance of a shortcut you just created). Both scenarios (wanting to create more shortcuts in the same section or wanting to adjust the new shortcut) seem about equally likely to me, so having to switch tabs would make it less convenient. I'm open to more feedback and consensus on this though.

In case you haven't noticed; you can change the relative size of the treeviews, to adjust for the two scenarios I described above. I might need to make that "sticky" between invocations of the dialog.

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

dterrahe commented 3 years ago

The dialog is now available standalone (outside preferences) for easier/quicker access. The two halves of the dialog now interact even more closely because selecting an action or module/category in the bottom half filters the top half to only show the relevant shortcuts. So having both visible at the same time is essential otherwise this would be much harder to use (and probably also not as obvious).

The shortcuts tree has quite a few columns and also somehow it makes sense to me to have the filter below it, but in theory the two panels could be trivially put next to eachother, using gtk_paned_new(GTK_ORIENTATION_HORIZONTAL);

Do you think it would be useful to make this toggleable by the user? image