dterrahe / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
2 stars 0 forks source link

Ctrl-A/Shift-Ctrl-A do not work in darkroom/map views #22

Closed ralfbrown closed 3 years ago

ralfbrown commented 3 years ago

Describe the bug/issue With current master's NGInput, it isn't possible to select-all/select-none on the filmstrip in darkroom or map views. I particularly need select none, as my desktop grabs Alt+mouse events, so it isn't possible to start a new selection with Alt+click on a thumbnail. That means resetting the selection requires Ctrl+click on every selected thumb or a trip to lighttable and back. Really annoying when manually geotagging in the map view....

To Reproduce

  1. Go to darkroom or map view
  2. Attempt to select all images on the filmstrip by pressing Ctrl-A. Note that nothing happens.
  3. Select a few images with Ctrl+click and/or Shift+Click.
  4. Attempt to clear the selection with Shift+Ctrl+A. Note that nothing happens.

Expected behavior Ctrl+A should cause all thumbs to become selected, while Shift+Ctrl+A should cause all to be deselected.

Cause Ctrl+A and Shift+Ctrl+A are bound to lib/select/... which act globally, but are only active where the Select module is available (which is only in lighttable view). There are also "views/thumbtable/select all" and "views/thumbtable/select none", but you can't assign the same shortcut to both lib/select/... and the corresponding views/thumbtable/... since the former is treated as global.

Additional Information It turns out that if you assign Ctrl+A/Shift+Ctrl+A to the views/thumbtable/ actions, the keys work as expected in all views. So that's at least a workaround.