search

dterrahe / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
2 stars 0 forks source link

NG Input: Pointer persists #8

Closed elstoc closed 3 years ago

elstoc commented 3 years ago

Click on the "define shortcuts" button and the mouse pointer changes to an 'x' and the button activates. Click on the icon a second time and the button deactivates but the pointer doesn't change. It seems the only way to get the arrow icon back is to click in the centre panel.

Ref: darktable-org#8078

dterrahe commented 3 years ago

Should not be a difficult one, hopefully. The pointers/cursors need new designs. That X on windows is completely invisible. So it would be good to get somebody with artistic bones in their body (not me) involved. But since the meaning of the X cursor could change based on your other suggestions (i.e. instead of being "inactive" or "normal mode" it would become a "click here for locally relevant shortcut configuration").

I'm thinking the button should have a keyboard related icon (something looking like the AWSD button group maybe; recognisable for gamers). And then this mouse cursor could be an arrow with a small scaled version of same logo attached.

The cursor while hovering over a mappable widget is a whole different question; how to signify that?

elstoc commented 3 years ago

If we're going to go with setting up the shortcuts in a separate dialog, and just use the mouse to select the subset of shortcuts to set up, we probably don't need to change the cursor at all. Keep it as an arrow and, depending on where the user hovers, an area of the screen is highlighted, with a tooltip saying "click to set up shortcuts for \<area>".

dterrahe commented 3 years ago

I'm not going to scrap the visual configuration, because I think it works well and is a very useful feature. The dialog setup will be an alternative way for those who prefer that. And obviously it is needed for those shortcuts that don't have a visual component and to configure/adjust extra features (speed/instance). So these are two complimentary approaches.

If the visual configuration is deemed confusing/dangerous for novice users, then this would be another candidate for an on/off switch in preferences. Or a ctrl-click on button to enable. I'm not really expecting that to be needed though, but I could definitely be wrong. Let's see.

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

dterrahe commented 3 years ago

The "define shortcuts" button can now be toggled on and off as usual. Also, right clicking exits mapping mode.

Left clicking opens the dialog with the screen element under the cursor selected in the action list (and the shortcut list filtered for that (group of) action(s)). It also exits mapping mode.