search

dterrahe / darktable

darktable is an open source photography workflow application and raw developer
https://www.darktable.org
GNU General Public License v3.0
2 stars 0 forks source link

NG Input: Not all buttons can be assigned #9

Closed elstoc closed 3 years ago

elstoc commented 3 years ago

There are a number of buttons that don't seem to be accessible to the NG Input system. Presumably they're part of phase 2?

For example, "darkroom/history/compress history stack", "darkroom/duplicate/duplicate", "darkroom/duplicate/original".

Hardly any of the widgets in the global color picker can be set, and none of the buttons in the histogram.

The multi-instance menu can't be set and neither can the enable/disable module button.

None of the bottom-panel buttons can be set.

Ref: darktable-org#8078

dterrahe commented 3 years ago

Correct. Those buttons are defined using different calls and aren't aware themselves which library/view they belong to. There needs to be some restructuring in bauhaus and in other dt widgets to properly support this and then this needs to be fixed in all the affected modules/views. That will cause the footprint of this PR to balloon (->continuous rebasing) so I've postponed all that work to later phases. Still not sure whether it should all go into the first merge (it is not a regression) but hopefully by then (June) I'll have made progress on the infrastructure changes and then possibly the wider rollout across the ui codebase could follow quickly after, in separate self-contained PRs.

github-actions[bot] commented 3 years ago

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

dterrahe commented 3 years ago

More buttons have been shortcutized, but there are still many that need to be ported. In some cases that is a simple linking, but in other cases (ratings, color labels) there is currently no framework link between the shortcut and gui element. That porting can be more easily done after the framework has been merged, rather than further growing this single PR with all consequences for conflicts requiring risky rebases.

Having said that, most bauhaus widgets (mostly combos) outside iops can now have shortcuts (except input formats/sources) and most of the bottom-right toggles in darkroom work (even their popups, using shortcut+right click. I'm waiting for the guides work to settle down before tackling that). The popup-menus that previously didn't work well because they appeared far from the cursor now behave in a more useful way. The presets menu effects are only partially implemented; previous/next requires new preset functionality that is not really shortcut specific so I didn't want to pollute this PR with it.

dterrahe commented 3 years ago

If there are still any buttons you think should have shortcuts please file FRs in the mean repo.