search

dteviot / WebToEpub

A simple Chrome (and Firefox) Extension that converts Web Novels (and other web pages) into an EPUB.
Other
729 stars 138 forks source link

Option to auto-skip errors #160

Open dteviot opened 6 years ago

dteviot commented 6 years ago

Request (https://addons.mozilla.org/en-GB/firefox/addon/webtoepub-for-baka-tsuki/reviews/1085751/)

Would greatly appreciate an option to auto-skip errors, especially "images not found" and "unable to create proper xhtml", though a simple skip all errors would still work for me :)

3dycosmo commented 6 years ago

In the chrome, we still need to pick either retry or cancel

dteviot commented 6 years ago

@3dycosmo Please give me URL(s) that has problems and the error message(s) that appear.

dteviot commented 6 years ago

Note to self: See: https://www.viget.com/articles/the-dialog-element/

c-h-u-c-k commented 4 years ago

I agree, the image parser breaks on ch371 of https://www.wuxiaworld.com/novel/emperors-domination. Can't get past it.

dteviot commented 4 years ago

@c-h-u-c-k I've just tried emperors-domination, and had no problems with all 2671+ chapters. I was using version 0.0.0.97 on chrome. There were a number of images that could not be fetched, but WebToEpub simply skipped them and recorded the issues.

You will need to provide more details for me to help you further.

  1. Describe what you do to get the error. e.g. Does it happen if you try to fetch just chapter 371? Does it happen if you try to fetch all chapters?
  2. Describe "parser breaks" in more detail. What does WebToEpub do? How does this differ from what you expect.
  3. Is there an error message? if so what's the error.
c-h-u-c-k commented 4 years ago

Error happens on page 371 consistently. I just grabbed just 370 to 372 and it triggered. Also happens on all chapter fetch. Here's the error:

is not a valid URL. urlHasFragment@moz-extension://ab414571-db9e-4606-a3be-23df7bdb7e42/js/ImageCollector.js:364:36 initialUrlToTry@moz-extension://ab414571-db9e-4606-a3be-23df7bdb7e42/js/ImageCollector.js:358:42 fetchImage@moz-extension://ab414571-db9e-4606-a3be-23df7bdb7e42/js/ImageCollector.js:298:31 fetchImages/temp</<@moz-extension://ab414571-db9e-4606-a3be-23df7bdb7e42/js/ImageCollector.js:108:29

dteviot commented 4 years ago

@c-h-u-c-k
I think I see part of the problem. The moz-extension suggests to me that you're not using the Chrome extension (with Chrome). I think you're using Firefox, but I'm not 100% sure. I just tried Firefox version 72.0.1, and it had no problems. Can you tell me what browser you are using Name and version? (And can you run the Chrome version, in Chrome as a test, to confirm that it works?)

For my notes, it looks like the Browser you're using is not correctly handling the following:

new URL("http://psdreview.com/wp-content/uploads/2012/11/Fantastic-Tree.jpg")

Alternate hypothesis: when site detects Firefox mobile being used, it does some sort of delay load of images, so the src value in the image tag is not legal, and when try to parse it, the parse fails.

c-h-u-c-k commented 4 years ago

Using Firefox for Android latest version 68.4.1. Maybe that's the issue... If so, maybe add a specific skip images advanced option to not even try them? As I generally don't care about pictures, just the text. Thanks

On Mon, Jan 13, 2020, 1:21 AM dteviot notifications@github.com wrote:

@c-h-u-c-k https://github.com/c-h-u-c-k I think I see part of the problem. The moz-extension suggests to me that you're not using the Chrome extension (with Chrome). I think you're using Firefox, but I'm not 100% sure. I just tried Firefox version 72.0.1, and it had no problems. Can you tell me what browser you are using Name and version? (And can you run the Chrome version, in Chrome as a test, to confirm that it works?)

For my notes, it looks like the Browser you're using is not correctly handling the following:

new URL("http://psdreview.com/wp-content/uploads/2012/11/Fantastic-Tree.jpg")

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dteviot/WebToEpub/issues/160?email_source=notifications&email_token=AAQFGVA6OTW5MM4DAQX7CXTQ5QXBTA5CNFSM4EW6Y6Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIYAKBA#issuecomment-573572356, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQFGVBHDPUOIKIS5UUZ34DQ5QXBTANCNFSM4EW6Y6ZQ .

dteviot commented 4 years ago

@c-h-u-c-k

If so, maybe add a specific skip images advanced option to not even try them?

It's may be a while before I can do that. Last time I looked at implementing that, it got complicated, fast, due to interactions with other options. Until then, are you able to use the extension with Firefox on Windows to create epubs?