dteviot / WebToEpub

A simple Chrome (and Firefox) Extension that converts Web Novels (and other web pages) into an EPUB.
Other
732 stars 139 forks source link

Out of Memory #179

Open minekasetsu opened 6 years ago

minekasetsu commented 6 years ago

I don't think this is what the extension is designed for, but I used it on lparchive.org, specifically https://lparchive.org/Legend-of-Mana-(by-Mega64)/ . The chapters was filled with a lot of gameplay pictures and animations, so they ended up being really big, but initially I found success making the first 18 chapters into a book (132mb). But when I tried to make the next 24 chapters into a book, It returned "out of memory", after all of the urls being processed. I tried to reduce the number of chapters to 18 so it's not much different from the previous one, but It still returned "out of memory".

I decided to manually end the process of that specific firefox tab (it took 300~500mb of memory even after the failure, according to task manager), closed the tab, and open it at a new tab. Then I find successs in making the book (18 chapters, 163mb).

I also found some other failure if I simply refreshed the tab instead of close and open it at a new tab, but I forgot what it said and I'm not willing to recreate the scenario. Sorry.

Additionally it might be nice if I can skip analyzing the starting url and immediately put the chapter urls. But I suspect my case was highly specific, and so the gain would be marginal at best.

dteviot commented 6 years ago

@minekasetsu I'm sorry, but I don't know what you're asking for. If you're trying to say, "The extension can run out of memory and crash". Then thank you, I'm aware of that. Unfortunately, there's not a lot I can do about it. If you're telling me that "Refreshing a tab does not release all memory". Thank you. I'll look into that. If it's something else, please tell me what it is you'd like me to do.

Synteresis commented 2 years ago

Note to Self

Look at https://github.com/jimmywarting/StreamSaver.js?

dteviot commented 2 years ago

Note to self: https://wicg.github.io/file-system-access