search

dtex / j5e

Framework for embedded devices using ECMA-419, the ECMAScript® embedded systems API specification, based on Johnny-Five's API
https://www.j5e.dev/
MIT License
64 stars 6 forks source link

sensor manifest appears to use within inconsistently #72

Closed phoddie closed 4 years ago

phoddie commented 4 years ago

The sensor manifest includes the withinablemodule as j5e/within

https://github.com/dtex/j5e/blob/3390ab33e1b55b7c89ceed58a6bc616aa97fafca/lib/sensor/manifest.json#L5

Later it tries to preload the module as j5e/withinable which fails because the module specifier is j5e/within:

https://github.com/dtex/j5e/blob/3390ab33e1b55b7c89ceed58a6bc616aa97fafca/lib/sensor/manifest.json#L9-L10

Should line 5 use j5e/withinable instead?

dtex commented 4 years ago

Yes, thank you for the catch. I waffled on the name and missed this.