search

dtgm / chocolatey-packages

chocolateynuget packages published on chocolatey.org
https://chocolatey.org/profiles/dtgm
Apache License 2.0
48 stars 110 forks source link

(Install4J) now maintained by tunisiano #706

Closed tunisiano187 closed 4 months ago

tunisiano187 commented 6 months ago

Hello, I've missed the portable one, i'll prepare it and ask for it too.

tunisiano187 commented 6 months ago

Added

gep13 commented 5 months ago

I will hold off on merging this one until you push a new package version.

gep13 commented 4 months ago

@tunisiano187 this PR looks good, but I noticed that you haven't pushed the updated metapackage install4j. Is that something that you are still planning on doing?

tunisiano187 commented 4 months ago

It's indeed what it should do, but, it was stuck... i've tryied something else

tunisiano187 commented 4 months ago

This correction worked, it's been pushed

gep13 commented 4 months ago

@tunisiano187 thanks for checking!

Happy to approve the package, as it is just a refresh of the existing package scripts, however, for future versions, you might want to think about removing the chocolateyUninstall.ps1 from the meta package, as this should no longer be required, as Chocolatey CLI will take care of that.

gep13 commented 4 months ago

@tunisiano187 thanks again for your help with this package, and all the other packages that you are working on!