search

dthain / basekernel

A simple OS kernel for research, teaching, and fun.
GNU General Public License v2.0
806 stars 110 forks source link

Fixed up to GNU99 Standard #188

Closed dthain closed 6 years ago

dthain commented 6 years ago

I get a bunch of fiddly warnings when compiling on gcc 4.8.5. I propose we set the code standard to GNU C99. (And also fix up some nested initializer warnings.) Does this work for everyone else?

ethanmw commented 6 years ago

Should point out that the build-cross-compiler script is set to use gcc 8.2, though Makefile.config doesn't default to using the cross-compiler. This code compiles fine on the 8.2 cross-compiler, but should we make the cross-compiler the default for consistency?

dthain commented 6 years ago

Well, I agree that we should generally be using the cross compiler. But it is also good hygiene to fix up bits of code that are not strictly conformant. And, we should be explicit about the code standard that we intend to support.