search

dthiendoan / liche-bot

Based on hubot for hipchat
5 stars 4 forks source link

[wip] Code refactor into classes, testing original functionality and improved multiplayer feature #4

Open david-zou opened 7 years ago

david-zou commented 7 years ago

[7/12/2017] Change(s) Made: Added highnoon game command. Currently a work in progress, as there are still some bugs. Refactored the entire codebase of highnoon to use classes.

Impact or Risk(s): The huge refactor created some bugs because the code was coupled with some of the deprecated data structures used to store relevant game data. My goal now is to reduce the amount of coupling so that the code will be easier to refactor and maintain in the future if further changes are needed.

Testing: Here are some of the test cases to consider (there will be more in the future as features in the game change):

1) User should be able to simply type &highnoon to create a game session with a max of 2 players by default or join an existing session 2) User should be able to type &highnoon <number> to create a game session with a max of players 3) User should be able to type &highnoon remove <player> to remove a player from the session if needed 4) User should be able to type &highnoon cancel to remove the current session 5) User should be able to type BANG! to shoot the other players when it is time to draw

More to come!

Fallback Procedure: Revert to previous working commit.

References: https://github.com/Liche/liche-bot/issues/2