search

dthigpen / dtcraft-datapacks

MIT License
6 stars 2 forks source link

Sorting Double Chest #3

Open carlwithaK opened 2 years ago

carlwithaK commented 2 years ago

I think there's an issue with sorting double chest. If there's more than 27 items in a chest it will delete anything after that and just leave 27 items in the double chest.

dthigpen commented 2 years ago

Thanks for finding that, must have only last tested with it sparsely populated. I will create a fix soon

carlwithaK commented 2 years ago

No rush, just wanted to check in on an update because my players really enjoy this feature! Thanks for your work!

dthigpen commented 2 years ago

Should be getting the fix pushed up today. Ended up being a lot more involved since I cannot combine partial stacks with looting mechanics. I'll finish up testing and push tonight

dthigpen commented 2 years ago

Published release v0.0.11 with the fix for double chest sorting. I'll keep this issue open for a while in case you still experience issues.

carlwithaK commented 2 years ago

Seems to work, but I tried it on a chest, rearranged some items, sorted again, and I get a message saying, "You cannot trigger this objective yet" but if I reload the datapack it works again

dthigpen commented 2 years ago

Hmmm. I tried to reproduce that with a new world and the datapack zip but could not. These two lines are repeated every tick,

scoreboard players reset @a dt.sort_chest
scoreboard players enable @a dt.sort_chest

so I'm puzzled how the objective (dt.sort_chest) would not be enabled for you after using it.

dthigpen commented 2 years ago

Actually it could be that the maxCommandChainLength was reached, or too many commands were executed to perform the sort. I will test that out. If it proves true I'll raise the limit and make another release.

carlwithaK commented 2 years ago

I tried uninstalling and reloading it again and it said inventory sorted upon reload. Maybe something is being left in my scoreboard that is throwing it off?

carlwithaK commented 2 years ago

I tried to replicate the issue, what I'm seeing is that it works for certain chest that I have, then when I run it on specific chest it breaks the code and it ends up not working for any chest at all.