Support default values for options

dthree / vorpal

Node's framework for interactive CLIs

http://vorpal.js.org

MIT License

5.64k stars 280 forks source link

Support default values for options #182

Closed jbrumwell closed 7 years ago

jbrumwell commented 8 years ago

This should resolve the default value portion of this ticket, https://github.com/dthree/vorpal/issues/52

Convert command.js to es6
Change signature of option method to option(flags, description, options) backwards compatibility with previous signature
Fixed linting errors in a couple of files
Added an options.default property that allows for setting default values
Added two tests for default values

dthree commented 7 years ago

Thanks. I like the idea, as well as your handling of autocomplete, which is taking the third parameter. Please fix the conflicts and the points I brought up and we should be good to go!

milesj commented 7 years ago

Was just about to file an issue about this and saw the PR. 👏

jbrumwell commented 7 years ago

@dthree changes made and conflicts avoided :)

milesj commented 7 years ago

@jbrumwell Can you rebase off master and make sure everything still works? I added Yarn support and updated all deps.

milesj commented 7 years ago

I'll go ahead and merge this and fix any inconsistencies, seeing as how the 2.0 version is a ways out. Thanks for the work!