search

dthree / vorpal

Node's framework for interactive CLIs
http://vorpal.js.org
MIT License
5.64k stars 280 forks source link

Feature request: Auto-complete when typing piped commands #22

Closed scotthovestadt closed 9 years ago

scotthovestadt commented 9 years ago

reverse hello | rev

Hit tab. No autocomplete.

Looks like it's possible to implement even with the API but would be nice to detect the pipe character and have it built in!

dthree commented 9 years ago

Good point - this would be good to have.

Not sure yet whether this will be tricky or simple to implement. I'll check it out.

scotthovestadt commented 9 years ago

I'll add this feature.

dthree commented 9 years ago

That'd be cool. Check out the ._exec command in index.js

scotthovestadt commented 9 years ago

I've made a pull request. Let me know if there's anything more I need to do to have it merged in!

dthree commented 9 years ago

Thanks! Looks good on cursory glance - I want to make sure it doesn't break more detailed use of autocompletion, such as on wat, which does some crazy things.

Could you rebase your branch with the linting I put in, and I'll try to get this merged as soon as possible!

scotthovestadt commented 9 years ago

Done.

dthree commented 9 years ago

Boom.