Explicit node_modules ignores in .flowconfig

dthree / vorpal

Node's framework for interactive CLIs

http://vorpal.js.org

MIT License

5.63k stars 278 forks source link

Explicit node_modules ignores in .flowconfig #275

Closed newoga closed 6 years ago

newoga commented 6 years ago

@milesj While migrating lib/autocomplete.js, flow was producing an error for not being able to find the lodash module.

This PR replaces the wildcard ignore with explicit ignores for specific modules that produce weird flow errors (right now it only appears eslint-plugin-jsx-a11y is causing issues). This allows flow to be able to detect the presence of installed modules for our dependencies.

milesj commented 6 years ago

Does lodash have flow defs in its module root? Usually you link them manually in the [lib] section, or by using flow-typed.

newoga commented 6 years ago

@milesj It did not. Normally in my projects I still allow flow type to infer node_modules, but since we're maintaining our own stubs, I can follow that pattern for lodash. I created PR #277 (adding the definition from flow-typed).