search

dthree / vorpal

Node's framework for interactive CLIs
http://vorpal.js.org
MIT License
5.64k stars 280 forks source link

Bump inquirer version #3

Closed Downchuck closed 9 years ago

Downchuck commented 9 years ago

inquirer@0.9.0 is about half the size, as they switched to "rx-lite" from the much larger rxjs package. They have also "fixed" their lodash dependency, though that one is including the full librayr (now the bulk of the distribution size).

dthree commented 9 years ago

Nice. I know the semver says as much, but are you aware of any breaking changes with that switch?

dthree commented 9 years ago

@Downchuck snap I upgraded inquirer, and it totally broke Vorpal haha.

Vorpal uses a ton of the internals of inquirer as it gets down and dirty on UI manipulation, so I'm digging in to find what changed. 1/10th the size is definitely an enticing goal to get working.

dthree commented 9 years ago

For the record, this is fixed :)

Downchuck commented 9 years ago

fixed in 1.0.4; https://github.com/dthree/vorpal/commit/3e676e9fa0038893d777ca9a720a1f85bbc3de4e

dthree commented 9 years ago

Fully fixed in 1.0.7. Pressing the tab key still had some unexpected ramifications.