search

dthree / vorpal

Node's framework for interactive CLIs
http://vorpal.js.org
MIT License
5.64k stars 280 forks source link

When installed as global NPM package, CTRL+C twice won't end process #55

Closed scotthovestadt closed 8 years ago

scotthovestadt commented 8 years ago

You can't kill it at all unless you manually pkill -9 node in another terminal.

dthree commented 8 years ago

Oh, interesting. Got it.

scotthovestadt commented 8 years ago

I've also discovered, at least in my project, although I'm returned to the command prompt when I kill the process via CTRL+C twice, the process isn't actually ending.

eliperelman commented 8 years ago

I've had this same issue as well, I added the following as a workaround:

process.on('SIGINT', () => process.exit(2));
dthree commented 8 years ago

Thanks for the insight @eliperelman , I'll check this out as soon as I can.

dthree commented 8 years ago

Okay could you please try this out again with v.1.5.1. @eliperelman @scotthovestadt

scotthovestadt commented 8 years ago

@dthree It doesn't work on my end. No change in behavior.

dthree commented 8 years ago

Rrrgh. I don't know why I still run Windows. Reproducing things sucks.

Do you have an example Vorpal project I can download globally to try this out myself?

scotthovestadt commented 8 years ago

I'll take a crack at it now.

dthree commented 8 years ago

Thanks. If you just publish something real quick with the latest, I'll try it out. If I can reproduce this, I'm sure it's a real quick fix.

scotthovestadt commented 8 years ago

I don't know if I just didn't install it correctly before or if something in the 1.5.2 fixed it, but it works now. You can close this out!

dthree commented 8 years ago

Yeeha! That closes 3 issues haha!