dthree / vorpal

Node's framework for interactive CLIs

http://vorpal.js.org

MIT License

5.64k stars 280 forks source link

Persisting command history #68

Closed jackyjieliu closed 8 years ago

jackyjieliu commented 8 years ago

36 Added persistent command history

Implementation can be overridden by overriding vorpal.cmdHistory as long as the interface is maintained

dthree commented 8 years ago

Looks really good! :+1:

How big is that localstorage module btw?
Would you be able to add some tests?

jackyjieliu commented 8 years ago

The downloaded package is 374B I will work on unit tests and update the pr

dthree commented 8 years ago

Nice!

Still working, or are you ready for merge?

jackyjieliu commented 8 years ago

Ready to merge unless you have any other suggestions

dthree commented 8 years ago

Looks good for the first iteration! Are you all wrapped up on the additions?

jackyjieliu commented 8 years ago

Yupp we can always add more to it later

dthree commented 8 years ago

Great! You're awesome. :+1:

dthree commented 8 years ago

Published v1.5.0.