search

dthree / vorpal

Node's framework for interactive CLIs
http://vorpal.js.org
MIT License
5.64k stars 280 forks source link

.prompt() should return a Promise. #74

Closed fiatjaf closed 8 years ago

fiatjaf commented 8 years ago

some methods of Vorpal (.exec, for example) return promises, while .prompt accepts a callback. Why not wrap this and return a promise instead?

dthree commented 8 years ago

Just have to do the work on this one.

Shakyamuni177te commented 8 years ago

I'll have a look into the issue see if there's anything I can do.

Also, I just had a job interview and it seems vorpal.js is well known enough for the people who were interviewing me to be aware of it already, and the people doing the interview seemed way ahead of the curve as far as new and emerging frameworks.

dthree commented 8 years ago

Hey, thanks. And that's awesome! :fire:

fiatjaf commented 8 years ago

@Shakyamuni177te are you still doing this?

scotthovestadt commented 8 years ago

Done.

dthree commented 8 years ago

:+1: