dthree / vorpal

Node's framework for interactive CLIs
http://vorpal.js.org
MIT License
5.64k stars 280 forks source link

fix using session delimiter as function not string #97

Closed mvayngrib closed 8 years ago

scotthovestadt commented 8 years ago

Looks good to me if I'm understanding the code correctly. @dthree ?

dthree commented 8 years ago

This looks fine, but I'm totally puzzled as to how this even worked before - it seems like passing in a function would throw an obvious error or make the delimiter a function string.

@mvayngrib :+1: on catching and fixing this, however can you please tell me what behavior led you to finding this, and how this behavior is different now? Thanks.

mvayngrib commented 8 years ago

@dthree i was hitting Ctrl+C mid-command and it printed a function on the screen. I searched for the function in the vorpal code and saw it was the delimiter function. Now it prints the actual string delimiter instead

dthree commented 8 years ago

Haha - got it. Thanks a lot for the fix!

mvayngrib commented 8 years ago

thanks for the lib!

dthree commented 8 years ago

:+1: