search

dtinit / data-transfer-project

The Data Transfer Project makes it easy for platforms to build interoperable user data portability features. We are establishing a common framework, including data models and protocols, to enable direct transfer of data both into and out of participating online service providers.
https://dtinit.org/docs/dtp-what-is-it
Apache License 2.0
3.57k stars 481 forks source link

Google Gmail Importer tests #363

Closed seehamrun closed 1 month ago

chamorajg commented 6 years ago

i would like to contribute for this project. Can you guys help me out on how to start and proceed with this issue ?

chamorajg commented 6 years ago

Can someone help me out ???

seehamrun commented 6 years ago

Hi! Thanks for helping out!

The Gmail importer and exporter live under extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/mail

We have some minimal tests under extensions/data-transfer/portability-data-transfer-google/src/test/java/org/datatransferproject/datatransfer/google/mail

A good place to start is reading through the makeup of our adapter plug in model to understand how these pieces fit together. Feel free to add onto the test from there (looks like there are a couple of TODOs left in the code).

holachuy commented 6 years ago

In addition to that, I would add:

As far as an existing example for an importer test, please see: https://github.com/google/data-transfer-project/blob/master/extensions/data-transfer/portability-data-transfer-google/src/test/java/org/datatransferproject/datatransfer/google/contacts/GoogleContactsImporterTest.java

We don't have a general test guidelines doc yet and would welcome any contribution you would like to make towards documentation if you are so inclined.

Here is a general guideline from the Google Testing Blog that may be helpful https://testing.googleblog.com/2008/08/by-miko-hevery-so-you-decided-to.html

chamorajg commented 6 years ago

Thank you guys for your response. I am going through the codebase now. It might take time to start but definitely do it. Once again thank you guys.

chamorajg commented 6 years ago

I have installed the docker images for running locally. How to get the API keys

holachuy commented 6 years ago

We have some general documentation here about API keys. Let us know if there is anything that is unclear https://github.com/google/data-transfer-project/blob/master/Documentation/Keys.md

chamorajg commented 6 years ago

I tried running the dtp using docker-image when I use the localhost link I am not able to authenticate using API keys it says

  1. That’s an error. Error: invalid_client The OAuth client was not found. I get this when I try to run it locally.
seehamrun commented 6 years ago

Hi, this happens if the API key/secret are misconfigured. Which service are you getting the error for? Please double check that the client ID and secret that are configured on the service, match what you are passing in the secrets file.

chamorajg commented 6 years ago

Google API keys. I get the key id but how to get the secret key. I am confused on how to choose the required API for the concerned application. Can you just help me out.

seehamrun commented 6 years ago

You find some details on the flow of creating an oauth client for Google here: https://developers.google.com/identity/protocols/OAuth2WebServer#creatingcred

If you already created the oauth client, you can view the ID and secret by going to the cloud console credentials page: https://console.developers.google.com/apis/credentials and selecting the oauth client you are trying to access.

Let me know if that makes sense, and please point out places where our documentation is lacking. Thanks!

chamorajg commented 6 years ago

Yes now it all works. I guess documentation lacks few information about OAuth registration.

cedricvanrompay commented 5 years ago

When creating an OAuth client, what do you put for "authorized domain" if your DTP instance runs on your laptop's localhost?

cedricvanrompay commented 5 years ago

Ok, well turns out you can put whatever domain you want and you still get OAuth credentials.

Also, I don't know why it's written “cedricvanrompay unassigned olsona 4 hours ago”. Really bad bug from GitHub ?..

AlenJoseph55 commented 1 year ago

Hey, Can I do the TODO's in the code?

bhupal9032 commented 1 year ago

i would like to fix this issue.

Abhi-y2003 commented 1 year ago

hey is this issue fixed can you assign me .

anishlukk123 commented 1 year ago

@bhupal. you can work on this

jaymasiwal commented 1 year ago

hi, I would like to fix this issue as I've very little prior experience with open source can you please help me out with it

EdmondLee958 commented 1 year ago

Hello me and my teammate will be working on this issue.

Olab23 commented 1 year ago

I would like to contribute for this project. Can you guys help me out on how to start and proceed with this issue ?

Klinkaaraa commented 1 year ago

Hello all is there any issue to fix. If so I would like to work on it. Can u guys suggest me??

Ameerjafar commented 1 year ago

I want to support this project. can somebody assist me in contributing to this project?

deepakchouhandc commented 1 year ago

I want to support and fix this issue but I don't know who to start.

DumitruDruta commented 1 year ago

Hello, I want to contribute to this issue. Is it still relevant?

Klinkaaraa commented 1 year ago

Yes sir.

On Tue, 5 Dec, 2023, 6:17 pm Dumitru, @.***> wrote:

Hello, I want to contribute to this issue. Is it still relevant?

— Reply to this email directly, view it on GitHub https://github.com/google/data-transfer-project/issues/363#issuecomment-1840728654, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCMTZF2GCJG36UJJRWUSV43YH4JWHAVCNFSM4E23DUZ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBUGA3TEOBWGU2A . You are receiving this because you commented.Message ID: @.***>

calumcalder commented 1 month ago

There's a single test and more could be added, but since GoogleMailImporter has not changed in 5 years I don't think this relevant any more.