dtinth / ThreadGPT

Alternative frontend to ChatGPT (gpt-3.5-turbo / gpt-4) with a thread-based interface
https://threadgpt.vercel.app
80 stars 23 forks source link

Enhancement: Use displayName for better to investigate on prod #11

Closed fResult closed 1 year ago

fResult commented 1 year ago
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
thread-gpt ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 10:01AM (UTC)
dtinth commented 1 year ago

@fResult I’m not sure about the displayName thing. When developing do you use pnpm run dev? If the component names show up when using pnpm run dev then no need to add displayName.

dtinth commented 1 year ago

Ohh, I just saw the title — on production. I don’t think it is necessary because it adds a maintenance burden. I want to keep this project as lean as possible.

On the component type, the convention for this project is this:

interface MyComponent {}
function MyComponent(props: MyComponent) {
  return <></>
}

So, no need to change to FC. That’s an extra import.

fResult commented 1 year ago

Okay, I see. Thanks for sharing krub.

Can I close PR?

dtinth commented 1 year ago

Sure, let’s close this for now. Cheers!