dtjohnson / xlsx-populate

Excel XLSX parser/generator written in JavaScript with Node.js and browser support, jQuery/d3-style method chaining, encryption, and a focus on keeping existing workbook features and styles in tact.
MIT License
957 stars 183 forks source link

row.hidden() and column.hidden() always return false #286

Open kcwitt opened 4 years ago

kcwitt commented 4 years ago

When parsing a worksheet, the row.hidden() and column.hidden() functions always return false even for rows and columns that are hidden in the worksheet.

Seems that the .hidden() functions internally use this._node.attributes.hidden === 1, but this._node.attributes.hidden seems to return "true"/"false" (as strings) (so the final result of === 1 is always false).