search

dtk01 / dtk

Read the Bible or other diatheke-accessible material in emacs
GNU General Public License v3.0
24 stars 10 forks source link

Misc changes #3

Closed yiufung closed 5 years ago

yiufung commented 5 years ago

The commit put initialization-related code within dtk-init. After that, dtk entrance logic is simplified.

thomp commented 5 years ago

Thanks for investing time in this. A lot of improvements.. Would you be willing to consider a couple of changes and then resubmit?

  1. L 173 "Text are..." -> "Text is..."
  2. I'd prefer to keep completion case-insensitive, especially for book selection, in DTK-BIBLE. It's lost in ed81bf6db9ea6b82a9a76a770092edad1d8a79bf with the removal of (let ((completion-ignore-case t)) ... when establishing the value of final-book. I think, in general, it will be more convenient to allow users to not worry about case when selecting the book. Is there a good rationale for being strict with case?
yiufung commented 5 years ago

Both issues are fixed now.

The latter is mistakenly removed as I have enable ivy-mode and it takes care of case-insensitiveness, leading me to think that the default behavior is already fine. In light of this, maybe it's a good idea to support different completion backends (helm, ido, ivy) by providing customized option such as dtk-completing-read-function, and users can set it to ivy-completing-read, helm-completing-read to their likings.