search

dtk01 / dtk

Read the Bible or other diatheke-accessible material in emacs
GNU General Public License v3.0
24 stars 11 forks source link

support different completion backends #5

Closed thomp closed 2 years ago

thomp commented 5 years ago

Per @yiufung's suggestion, support different completion backends. Consider providing customized option such as dtk-completing-read-function. The symbol would point to the desired completion backend (e.g., ivy-completing-read, helm-completing-read, ...).

yiufung commented 5 years ago

I planned to work on this, but a second thought come by: if user already enable ivy-mode or helm-mode, completing-read is automatically redirected to these reading functions, so the option becomes not necessary. It's not an urgent option, so I'd work on other features first.

dtk01 commented 5 years ago

Agreed - this seems a relatively minor issue.

thomp commented 2 years ago

As completing-read is redirected with most completion frameworks, this issue can be put on the back burner for the time being.