search

dtmilano / AndroidViewClient

Android ViewServer and ADB client
Apache License 2.0
1.62k stars 347 forks source link

platform.system() could return a value of Java causing the adb look up to fail on a windows system. #138

Closed washyu closed 8 years ago

washyu commented 9 years ago

Needed to do and extra check if platform.system() returns the value of 'Java' and check and the OS environment variable to see if we are in a Windows environment. The os.getenv() will default to none if it not set.

dtmilano commented 9 years ago

Can you please tell me more about the case where you need 'Java' as the OS?

washyu commented 9 years ago

When I am testing my automation from the Eclipse IDE since it is running with JAVA any debug run will also be in this same JAVA environment hence the OS will be reported as JAVA.

dtmilano commented 9 years ago

Are you using PyDev?

On Wed, Mar 25, 2015 at 9:26 AM, washyu notifications@github.com wrote:

When I am testing my automation from the Eclipse IDE since it is running with JAVA any debug run will also be in this same JAVA environment hence the OS will be reported as JAVA.

— Reply to this email directly or view it on GitHub https://github.com/dtmilano/AndroidViewClient/pull/138#issuecomment-86022524 .

Have you read my blog ? http://dtmilano.blogspot.com android junit tests ui linux cult thin clients

washyu commented 9 years ago

Sorry I was going to mention that. Yes I am using pydev.

Sent via the Samsung Galaxy Note® 4, an AT&T 4G LTE smartphone

-------- Original message -------- From: Diego Torres Milano notifications@github.com Date: 03/25/2015 12:32 PM (GMT-08:00) To: dtmilano/AndroidViewClient AndroidViewClient@noreply.github.com Cc: washyu washyu@hotmail.com Subject: Re: [AndroidViewClient] platform.system() could return a value of Java causing the adb look up to fail on a windows system. (#138)

Are you using PyDev?

On Wed, Mar 25, 2015 at 9:26 AM, washyu notifications@github.com wrote:

When I am testing my automation from the Eclipse IDE since it is running with JAVA any debug run will also be in this same JAVA environment hence the OS will be reported as JAVA.

— Reply to this email directly or view it on GitHub https://github.com/dtmilano/AndroidViewClient/pull/138#issuecomment-86022524 .

Have you read my blog ? http://dtmilano.blogspot.com android junit tests ui linux cult thin clients

Reply to this email directly or view it on GitHub: https://github.com/dtmilano/AndroidViewClient/pull/138#issuecomment-86184700