dtn9197 / herocard

this repository uses web components to make a herocard
MIT License
0 stars 0 forks source link

super.properties #7

Closed btopro closed 4 years ago

btopro commented 4 years ago

https://github.com/dtn9197/herocard/blob/6672dc674a57a37de3c8076e355fe3ed443f2540/src/HeroCard.js#L175

This isn't able to correctly leverage accent-color or the dark property because they come from SimpleColors which also implements static get properties.

So, to merge the two you need a spread ... operator or...

return {...super.properties, and then these https://github.com/dtn9197/herocard/blob/master/src/HeroCard.js#L176-L179