search

dtolnay / erased-serde

Type-erased Serialize, Serializer and Deserializer traits
Apache License 2.0
709 stars 36 forks source link

Add support for 128bit numbers #24

Closed KodrAus closed 6 years ago

KodrAus commented 6 years ago

Hi there!

I ran into a case recently where I needed 128bit number support in erased-serde so have taken a stab at implementing it here.

I've gone with a conservative route of defaulting the conditional trait methods even though I think the de::Visitor is actually private. This should be a non-breaking change.

Please let me know if you'd like me to throw a test case in there somewhere or if there's anything you'd like done differently.

KodrAus commented 6 years ago

Done :+1: It also turns out I'd missed a few of the impl blocks the first time around

dtolnay commented 6 years ago

Nicely done. I published 0.3.6 containing this change.