search

dtolnay / quote

Rust quasi-quoting
Apache License 2.0
1.32k stars 90 forks source link

Recent update has a breaking change #241

Closed ShayBox closed 1 year ago

ShayBox commented 1 year ago

It appears a recent patch update has made breaking changes, causing diesel errors https://github.com/diesel-rs/diesel/issues/3541

dtolnay commented 1 year ago

I think this change was all right, since that trait Diesel is using has never been a public API.

ShayBox commented 1 year ago

I don't know much about the API and that's your decision, but in my opinion if the API wasn't meant to be public and/or usable then it shouldn't have been accessible.

You should assume things are or will be used if accessible, even if you didn't intend it, and making a breaking change to one of the most used libraries can break other large projects.

dtolnay commented 1 year ago

The public API is documented here: https://docs.rs/quote/1. If something is not there, then it is not a public API.