search

dtolnay / rustversion

Conditional compilation according to rustc compiler version
Apache License 2.0
326 stars 15 forks source link

Drop Edition 2018? #27

Closed JeremyRubin closed 3 years ago

JeremyRubin commented 3 years ago

Is it possible to make this crate have an edition of 2015 implicitly so that it can be used on pre-1.31 code?

dtolnay commented 3 years ago

It's possible. What compiler version do you care about support for?

JeremyRubin commented 3 years ago

rust-bitcoin targest MSRV 1.29; not a huge deal because issues with dev-dependencies means that this won't exactly fix our problem either, but perhaps worth addressing in general for rustversion as I'd imagine being able to use version switching macros on the widest set of versions is a good goal.

dtolnay commented 3 years ago

1.29 does not support attribute macros so that would require a different approach than rustversion.