search

dtolstyi / node-chromium

Node.js package that downloads and provides Chromium for your project
101 stars 33 forks source link

Enable use of download mirrors #28

Closed ricksbrown closed 4 years ago

ricksbrown commented 4 years ago

Primarily concerned with downloading specific revisions from an on-prem/private mirror in a controlled corporate environment with no access to download binaries from the cloud.

UPDATE:

So PR #27 is goodness and useful for the alternate download mirror too but conflicts with the changes I had in this PR.

I have therefore incorporated the changes from #27 into this PR and then built on that idea quite a bit. If this is too much I can pop the top couple of commits off and give it to you as a separate PR.

dtolstyi commented 4 years ago

This is absolutely amazing PR, @ricksbrown ! Thank you so much! I really love it. So much work done and of top quality! Wow!

ricksbrown commented 4 years ago

Awesome thanks man, this is going to be very useful.

dtolstyi commented 4 years ago

Yes, for sure! Thank you once more! I'm trying to resolve security issues of dependent modules now and will release a new version soon.