search

dtpublic / malhar-angular-dashboard

Generic Dashboard/Widgets functionality with AngularJS (directive)
http://datatorrent.github.io/malhar-angular-dashboard/#/
Apache License 2.0
737 stars 297 forks source link

Angular Gridster instead of jquery-sortable #87

Open sclausen opened 10 years ago

sclausen commented 10 years ago

For a more consistent layout I propose angular-gridster as a replacement for angular-ui-sortable

andyperlitch commented 9 years ago

@sclausen sorry for the delayed response. We are open to switching angular-gridster (or maybe making it a configuration option / optional dependency?). Can you make a pull request?

awashbrook commented 9 years ago

We would also be interested

andyperlitch commented 9 years ago

My only beef with gridster is that the height of the widgets cannot be determined by the height of the content. This means that every widget will need to be height-aware, or have something like overflow:auto in its css. Thoughts on this anyone?

awashbrook commented 9 years ago

...finishing my thought: we would be interested in minimising the dependencies of Malhar dashboard framework, leaving decisions on heavy libraries like jquery-ui to webapps.

https://github.com/ManifestWebDesign/angular-gridster/issues/2

From the above looks like gridster finally have their own DnD implementation and no longer require jquery-ui.

Can you consider ditching angular-ui-sortable and jquery-ui entirely?

zhx828 commented 9 years ago

Agree with above. Would suggest add layout control by users. Packery also a good choice. Glad to help if needed to push some changes.

andyperlitch commented 9 years ago

I'm going to give ng-sortable a try for v1.0.0... it looks like it has matured a fair amount in the last six months.

sclausen commented 9 years ago

ng-sortable hase the same problem as angular-ui-sortable. if the cells are not equal sizes the layout is messed up. for example angular-gridster has relative cell-sizes which makes the layout more consistent.

andyperlitch commented 9 years ago

Yeah, I gave it a shot and it was not too pretty... will give gridster another look. My beef with gridster is that it has fixed height for all elements :-/ this can be pretty hard to deal with for certain widget content.

andyperlitch commented 9 years ago

removing this from the 1.0.0 milestone as this is probably achievable using a custom dashboard template. If someone else wants to add this option, i am open to PRs.

artoliukkonen commented 9 years ago

We choose to switch to Gridster in our project, so I forked this repo and made the changes. It's working pretty fine I'd say. https://github.com/SC5/malhar-angular-dashboard

Disclaimer: haven't touched to tests (possibly broken), haven't touched to demo (completely broken), switched to Foundation instead of Bootstrap (just because we're using it in our project). In case someone chooses to try our version, feel free to contact us for guidance.

rihabesx commented 8 years ago

Hi artoliukkonen! I am interested in the gridster fork but my project uses bootstrap. Could you please tell me what changes are required to make it work as gridster/bootstrap instead of gridster/foundation.

Also what is the possibility of getting the demo application to work. This is simplified version and will help a lot. Thanks.