search

dtr-org / unit-e-project

Unit-e project information
MIT License
13 stars 4 forks source link

Mergeable doesn't detect the `wip` label #103

Open cornelius opened 5 years ago

cornelius commented 5 years ago

Mergeable is supposed to block pull request from merging which have the wip label set. This doesn't seem to work anymore. I saw it on https://github.com/dtr-org/unit-e-docs/pull/102.

This is kind of a special pull requests because it changed the mergeable configuration, but the wip config was not touched, so it shouldn't have made a difference. Another weird thing was that mergeable hang after the pull request was approved. Changing labels retriggered it successfully but also showed the problem with the wip label.

scravy commented 5 years ago

That's proably upper vs lower case.

cornelius commented 5 years ago

The configuration seems to look for lower case (as is the label): https://github.com/dtr-org/unit-e-docs/blob/8b0b8cfb292e0f1a3ba98558f49178b660e931ee/.github/mergeable.yml#L8

scravy commented 5 years ago

Interesting. Did it look for lower case before too?

Does the WIP: mechanism for titles still work?

cornelius commented 5 years ago

This setting was the same before. I will test what works and will try to find a solution.

cornelius commented 5 years ago

I couldn't reproduce the issue, neither in a separate repo, nor in this repo. I'll watch how it behaves with future pull requests.

The regular expression is applied with the case insensitive flag in the code, so that can't be the issue. Good to know that the case doesn't matter, though.