search

dtr-org / unit-e-project

Unit-e project information
MIT License
13 stars 4 forks source link

Decide if to use DCO #19

Closed cornelius closed 6 years ago

cornelius commented 6 years ago

To make sure that code contributions are legally clean and authors have the rights to contribute it's helpful to define some mechanism which makes this explicit. One good option which is for example used by the Linux kernel is the Developer Certificate of Origin (DCO).

I would suggest to create an ADR which outlines this decision including rationale and consequences such as which git instructions to use, which tools to use to check commits, etc., and then decide about it.

Gnappuraz commented 6 years ago

yes, I think an ADR would be great.

scravy commented 6 years ago

Also goes together with https://github.com/dtr-org/unit-e-docs/issues/22

I am in favor of this. Yeah maybe an ADR is an okayish form for this, then again we could also have a PR on unit-e and just vote over there. After all that's probably where it should finally go and be pointed out?

cornelius commented 6 years ago

By the way, this is how the Linux kernel does it: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

cornelius commented 6 years ago

I think an ADR is good here because it can provide additional context you would normally not put into the instructions. I created a proposal now: #47.

cornelius commented 6 years ago

ADR done and accepted in https://github.com/dtr-org/unit-e-docs/pull/47

Instructions still have to be added to CONTRIBUTING.md: https://github.com/dtr-org/unit-e/issues/217