Closed scravy closed 5 years ago
I think we better remove msg_witness_block
. Because why make a distinction? It is a block. And we don't have non-witness ones
We can do that. For the sake of clarity when reviewing I would prefer to do it in two steps:
msg_block
with witness block (makes it clear which places had to be touched and what was affected)msg_witness_block
to msg_block
(this latter step should be trivial then)I did go with making it msg_block
in one shot... #1029
In https://github.com/dtr-org/unit-e/pull/798 only the minimally necessary adjustments were done to functional tests to make them pass. This leads to confusion sometimes when working on them as blocks seemingly arbitrary fail to validate when introducing new features.
Since all our blocks are witness blocks
msg_block
should be swapped completely in favor ofmsg_witness_block
in functional tests.