dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

Use msg_witnessblock instead of msg_block in all functional tests #1023

Closed scravy closed 5 years ago

scravy commented 5 years ago

In https://github.com/dtr-org/unit-e/pull/798 only the minimally necessary adjustments were done to functional tests to make them pass. This leads to confusion sometimes when working on them as blocks seemingly arbitrary fail to validate when introducing new features.

Since all our blocks are witness blocks msg_block should be swapped completely in favor of msg_witness_block in functional tests.

AM5800 commented 5 years ago

I think we better remove msg_witness_block. Because why make a distinction? It is a block. And we don't have non-witness ones

scravy commented 5 years ago

We can do that. For the sake of clarity when reviewing I would prefer to do it in two steps:

scravy commented 5 years ago

I did go with making it msg_block in one shot... #1029