search

dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

update help message for getblockheader and getblock (#963) #1028

Closed spiritlcx closed 5 years ago

spiritlcx commented 5 years ago

The help texts for the RPC messages didn't match the actual information returned by getblockheader and get block.

"witnessmerkleroot" and "finalizercommitsmerkleroot" are added and "nonce" is removed

Fixes #963 Signed-off-by: Chenxi Li spiritlcx@gmail.com

scravy commented 5 years ago

Hi @spiritlcx! Thank you for your contribution!

It is customary for the ones doing the merge to just copy the description from the pull request into the commit message for the merge commit. As such the help-text which is in the description textbox by default should not be in there (this is also why the first line renders as a heading, as there are these --- below it which should not be there).

As such it would be great if you could brush up the description a little bit :-)

spiritlcx commented 5 years ago

Hi @spiritlcx! Thank you for your contribution!

It is customary for the ones doing the merge to just copy the description from the pull request into the commit message for the merge commit. As such the help-text which is in the description textbox by default should not be in there (this is also why the first line renders as a heading, as there are these --- below it which should not be there).

As such it would be great if you could brush up the description a little bit :-)

Hi @scravy ! Thanks for the comments, I have corrected it.

cornelius commented 5 years ago

ACK https://github.com/dtr-org/unit-e/pull/1028/commits/d0602168db31980a946509972b757bce6b5166e4

cornelius commented 5 years ago

@spiritlcx congrats for your first pull request on unit-e 😃

spiritlcx commented 5 years ago

@spiritlcx congrats for your first pull request on unit-e 😃

Thanks very much! I will try to understand the architecture and the code deeply and make more pull requests. First it's good to start with fixing bugs.