Functional tests witness messages follow up

dtr-org / unit-e

A digital currency for a new era of decentralized trust

https://unit-e.io

MIT License

45 stars 15 forks source link

Functional tests witness messages follow up #1036

Closed scravy closed 5 years ago

scravy commented 5 years ago

Fixes #1032, Follow up to #1029

Removes the with_witness named argument from CBlock.serialize(). p2p_segwit requires non-witness serialization for computing the proper block weight, which is why an explicit serialize_without_witness has been added (this is the same as existing design on CTransaction).

Drops msg_witness_blocktxn in favor of msg_blocktxn, which now uses serialization with witness by default and unconditionally.

AM5800 commented 5 years ago

utACK f2cbccb So we can not completely get rid of serialize_without_witness and alike... So sad