search

dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

Rename functional tests #1074

Closed Gnappuraz closed 5 years ago

Gnappuraz commented 5 years ago

This PR renames all the functional tests from esperanza_ to finalization_ as they should as per https://github.com/dtr-org/unit-e-project/blob/master/adrs/ADR-0025.md.

pep8speaks commented 5 years ago

Hello @Gnappuraz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-05-07 12:03:38 UTC
frolosofsky commented 5 years ago

I doubt about finalization_finalizationstate.py, should't it be finalization_state.py simply? The same would happen when we move FinalizationState to the finalization namespace. On the one hand, finalization::FinalizationState sounds odd, on the other, the finalization::State is too generic, moreover we have ValidatorState in the same namespace... Would be nice to collect opinions in this PR so that we can move forward with some decision about this naming.

Gnappuraz commented 5 years ago

@frolosofsky I think finalization_finalizationstate.py is completely fine. We already have proposer::Proposer, I don't see a problem with that.

scravy commented 5 years ago

utACK e9abaaa84b82374c2650b993496b7202fad4f1ca