search

dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

Enable lint-python.sh for functional tests #1090

Closed cmihai closed 5 years ago

cmihai commented 5 years ago

This commit adds a PEP8 checker to the lint-all checks executed in Travis.

Now that we have @pep8speaks, this check is not as useful as before, so there's also the option of not including it.

pep8speaks commented 5 years ago

Hello @cmihai! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-05-10 08:55:23 UTC
frolosofsky commented 5 years ago

The only small disadvantage I see currently is that if Lint stage doesn't pass on Travis, other tests are not running and it can be a bit annoying, e.g. I pushed changes to see if they pass on all platforms and after an hour I see that tests didn't run because of the Lint. Would be nice if these two stages are executed in parallel or make Lint the last one.

You will get report in a minute usually. You can also configure the pre-commit hook to inform you about lint issues (see this and feel free to extend and contribute).

cmihai commented 5 years ago

@kostyantyn I get your argument, but this can be mitigated by configuring lint-all.sh as a post-commit hook. Changing the order of the build stages can be discussed with the team and we could open a new PR for it.