search

dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

Remove dead code in Esperanza-related files #1107

Closed castarco closed 5 years ago

castarco commented 5 years ago

Signed-off-by: Andres Correa Casablanca andres@thirdhash.com

frolosofsky commented 5 years ago

These things look like utility functions which were used previously, but "dead" at the moment. Who knows if we will need them again, further?

I'm fine with deleting the dead code, but doubt about special cases of utility code. I'm not sure it's ok to delete them, because then we (maybe) will need to write it again. In my opinion, it would be better to simply add test suites for these two functions instead. What do you think?

scravy commented 5 years ago

Reminds me of: https://github.com/bitcoin/bitcoin/pull/15814

„If you liked it you should have put a test on it“

castarco commented 5 years ago

I think we could keep some gists in case we need to save this code for debug purposes.

https://gist.github.com/castarco/74a2074104647426780191edd4dead9a