search

dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

Don't set epochLength=5 in regtest as it's a default value #804

Closed kostyantyn closed 5 years ago

kostyantyn commented 5 years ago

The reason for dropping this parameter is to show clearly which parameters are required to be changed.

In the follow-up PR I'll adjust other tests to default epochLength=5 where it's not required to have a longer one. The reason is to reduce the debug.log in case the test fails.

Signed-off-by: Kostiantyn Stepaniuk kostia@thirdhash.com

frolosofsky commented 5 years ago

Personally, I'd use epochLength=5 for explicitness.

What the problem this PR solves?

kostyantyn commented 5 years ago

@frolosofsky to show precisely which parameters must be set to run the test. E.g., I am debugging the test and want to start the node in regtest, I copy all the parameters the test tells me because they are not default ones. If we keep default ones, then logically we need to list them all.

edited:

What the problem this PR solves?

  1. Makes it more convenient to replicate nodes locally as fewer parameters must be set. Easier to understand which parameters influence the test.
  2. You don't need to ensure that all the nodes have the same configuration. If you change epoch, you need to pass it to all the nodes.