This PR contains the changes from the latest Bitcoin 0.17.1, adapted for Unit-e. It still needs quite some work before it can be merged with a clean conscience.
What works: It compiles, launches, the unit tests work, and some functional tests too. I've marked a few spots in the C++ code which need attention with MIHAI:.
The plan is to fix the remaining functional tests in this branch, then squash all of the fixes into the merge commit, review the code (as much as possible) for any glaring functional issues, and finally merge.
Spoiler alert: Here are some of the things that changed in Bitcoin 0.17, as compared to 0.16:
The wallet "safe mode" was removed.
Address "accounts" were removed from most places, and renamed to "labels" in the rest.
Wallets can now have status flags attached to them. Right now, the only one is WALLET_FLAG_DISABLE_PRIVATE_KEYS, but 0.18 adds another one for empty wallets.
Fixes #41
This PR contains the changes from the latest Bitcoin 0.17.1, adapted for Unit-e. It still needs quite some work before it can be merged with a clean conscience.
What works: It compiles, launches, the unit tests work, and some functional tests too. I've marked a few spots in the C++ code which need attention with
MIHAI:.The plan is to fix the remaining functional tests in this branch, then squash all of the fixes into the merge commit, review the code (as much as possible) for any glaring functional issues, and finally merge.
Spoiler alert: Here are some of the things that changed in Bitcoin 0.17, as compared to 0.16:
WALLET_FLAG_DISABLE_PRIVATE_KEYS, but 0.18 adds another one for empty wallets.