[After #860] Remove obsolete coins view database Upgrade logic

dtr-org / unit-e

A digital currency for a new era of decentralized trust

https://unit-e.io

MIT License

45 stars 15 forks source link

[After #860] Remove obsolete coins view database Upgrade logic #873

Closed frolosofsky closed 5 years ago

frolosofsky commented 5 years ago

As @Nizametdinov pointed out during recent code review CCoins and CoinsViewDB::Upgrade should be deleted as we do not suppose to recover from legacy data representation.

kostyantyn commented 5 years ago

ConceptACK https://github.com/dtr-org/unit-e/pull/873/commits/3bfbd8e937fb5bbfd9211e425cfbb739be498605 However, we have many such things that need to be cleaned up and don't affect the working code. would be good to postpone further refactorings as it takes time to write, review them and extra work for rebasing with upstream master. I can see it's nice to do once we rebased with 0.17.1

Gnappuraz commented 5 years ago

I agree with @kostyantyn, nice clean up but we can wait to merge this.