Add max stake split - Githubissues

dtr-org / unit-e

A digital currency for a new era of decentralized trust

https://unit-e.io

MIT License

45 stars 15 forks source link

Add max stake split #879

Closed Gnappuraz closed 5 years ago

Gnappuraz commented 5 years ago

This PR introduces an hard-coded parameter that sets the max numbers of stake output pieces to 1024.

scravy commented 5 years ago

NACK hardcoded parameter.

Gnappuraz commented 5 years ago

@scravy you would then prefer to have it passed as an argument for the client, right?

scravy commented 5 years ago

I do not know anything about this and its purpose.

Is this a user-definable setting? Should go to Settings (settings.h, settings.cpp) as stake_split_threshold and stake_combine_maximum
Is this a property of the blockchain, i.e. a blockchain::Parameters item? It should go there
- In this case: Does it require validation? Is this a consensus rule? Most likely if it goes there

In any case: How does it interact with stake_split_threshold? Which one takes precedence?

castarco commented 5 years ago

In general, I'm missing a why this is done. I also agree with @scravy that maybe this change should be applied on different parts of the code depending on its intended purpose.

Gnappuraz commented 5 years ago

I'm closing since this was a draft idea and I didn't even put a clear description. Not worth the time for anybody to check this atm.