Prevent multiple deposits

dtr-org / unit-e

A digital currency for a new era of decentralized trust

https://unit-e.io

MIT License

45 stars 15 forks source link

Prevent multiple deposits #894

Closed Gnappuraz closed 5 years ago

Gnappuraz commented 5 years ago

At the moment a node is accepting multiple deposit operations if the address is different from the first one used to init the finalizer. This is obviously a bug and should not be permitted. Another deposit should not be allowed before the actual withdraw, hence the deposit test after logging out.

Gnappuraz commented 5 years ago

esperanza_admin_full_cycle.py breaks because another deposit is being performed after the withdraw. The test was working just by chance because depositing after withdraw is not currently correctly handled. This problem appeared during development of this PR. https://github.com/dtr-org/unit-e/pull/917 fixes the root cause, after that this test should pass again.

Gnappuraz commented 5 years ago

@kostyantyn @frolosofsky @Ruteri the test has been fixed. Would be great if you could review again.