Drop paamayim nekudotayim

scravy commented 5 years ago

During review of #900 we discussed about the need for the scope resolution operator in injector.h.

The arguments pro and cons are:

Due to the names which overlap with some global symbols (Settings vs Settings) it clearly distinguishes these
- When applied to one it should be applied conistently to all (which at present it is not)
- It's ugly and alien syntax
- Why stop? Could also be done to namespaced items ::staking::ActiveChain

It's left as an exercise for the reviewer which argument is in favor of what side ;-)

This pull request drops all of them. Let's discuss :-)

@Nizametdinov I added you as a reviewer specifically as I commented on one of your pull requests with directly conflicting advice :D

Signed-off-by: Julian Fleischer julian@thirdhash.com

castarco commented 5 years ago

not ACK nor NACK. I think this kind of discussion will reappear some time in the future whenever we have new contributors.

So... whatever we decide, and whatever are our reasons, I vote to put that in our coding style guidelines. I know we are following the Google's style guide, but we could have an addendum.

cornelius commented 5 years ago

From my point of view it's preferable to drop the scope resolution operator where it's not needed by the compiler. I perceive the code as more readable this way. I would tend to rather choosing names in a way that they don't conflict (or appear to conflict).

utACK.

scravy commented 5 years ago

I added a note to the developer notes: https://github.com/dtr-org/unit-e/pull/918/commits/c49f8f65969252e00e5a1aa8d13a44400db0502d

cornelius commented 5 years ago

utACK https://github.com/dtr-org/unit-e/commit/c49f8f65969252e00e5a1aa8d13a44400db0502d

dtr-org / unit-e

Drop paamayim nekudotayim #918