search

dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

esperanza_logout.py is floating #932

Closed kostyantyn closed 5 years ago

kostyantyn commented 5 years ago 
 test  2019-04-10 14:29:31.120000 TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
  File "/home/travis/build/dtr-org/unit-e/build/unit-e-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 156, in main
    self.run_test()
  File "/home/travis/build/dtr-org/unit-e/build/unit-e-x86_64-unknown-linux-gnu/test/functional/esperanza_logout.py", line 68, in run_test
    self.wait_for_transaction(deptx_1, 60)
  File "/home/travis/build/dtr-org/unit-e/build/unit-e-x86_64-unknown-linux-gnu/test/functional/test_framework/test_framework.py", line 367, in wait_for_transaction
    % (txid, presence))
RuntimeError: Failed to wait for transaction 621f883f2c059d5d13f003d9e36f38acc0cfa4e8f0d2f7c04f7b323a541ee068. Presence: {0: True, 1: True, 2: False}

log.txt

frolosofsky commented 5 years ago

@kostyantyn Could you please attach the full log instead the link next time you fill an issue? It's what I can see by following you link:

This job was cancelled because the "Auto Cancellation" feature is currently enabled, and a more recent build (#4557) for branch master came in while this job was waiting to be processed.

Anyway I'm trying to reproduce the issue on the master.

kostyantyn commented 5 years ago

@frolosofsky It's because I opened it as a placeholder, assigned myself and commented that I am on it on slack. There is a PR which reproduces it https://github.com/dtr-org/unit-e/pull/936 and was opened yesterday.

If you take it, then good, I'll remove myself from this ticket, there is no need to do the same work twice.

frolosofsky commented 5 years ago

Huh our PRs are pretty similar, take a look on this guy: #938.

frolosofsky commented 5 years ago

Besides that, I think, we shouldn't use issue tracker for storing placeholders further. It's misleading a lot.

kostyantyn commented 5 years ago

@frolosofsky I agree that this ticket didn’t have a proper description. I’ll make sure that new issues I’ll create will have all the available information in the ticket.

But please, contact previous assignee of the ticket about the progress and continue from it. No need to work in parallel as it leads to waste of time.