dtr-org / unit-e

A digital currency for a new era of decentralized trust
https://unit-e.io
MIT License
45 stars 15 forks source link

Fix floating esperanza_withdraw #950

Closed frolosofsky closed 5 years ago

frolosofsky commented 5 years ago

The issue happens when finalizer propagate transaction and fails due to short timeout given from the test suite. Every other similar check in the test passes every time because they work with finalizer commits, but this one is a regular transaction which propagation might be delayed up to 148 seconds in the worst case scenario. On the other hand, some developers advocate using custom timeouts to reduce execution time of failed tests, that unfortunately leads to QA degradation and surprising results when being ran on unusual configurations.

Closes #943.

frolosofsky commented 5 years ago

Survived 200 runs on Travis: https://travis-ci.com/dtr-org/unit-e/builds/107997854.