Small proposer cleanups

dtr-org / unit-e

A digital currency for a new era of decentralized trust

https://unit-e.io

MIT License

45 stars 15 forks source link

Small proposer cleanups #964

Closed scravy closed 5 years ago

scravy commented 5 years ago

~removes the not proposing this time log message (this was already pointed out during review back then by @frolosofsky)~
adds a critical section for start/stop of the proposer to prevent any races here (it's not invoked from multiple places, but better safe than sorry)
removes the not started, nothing to stop debug message
fixes proposer status for proposerstatus RPC and adds some more

Signed-off-by: Julian Fleischer julian@thirdhash.com

scravy commented 5 years ago

It's an extremely useful log. I'm depending on it in many ways in normal usage of the client. E.g. it was the log that helped us determine cause of delays in proposing (it was coming in slightly too late).

Interesting. Okay then I drop this change.

scravy commented 5 years ago

@Ruteri https://github.com/dtr-org/unit-e/pull/964/commits/b80b75f26d8b66384ee02fcc6535e96b1a5958fe