Drop dead code in CWallet

dtr-org / unit-e

A digital currency for a new era of decentralized trust

https://unit-e.io

MIT License

45 stars 15 forks source link

Drop dead code in CWallet #982

Closed castarco closed 5 years ago

castarco commented 5 years ago

Signed-off-by: Andres Correa Casablanca andres@thirdhash.com

castarco commented 5 years ago

NACK because #873 (comment)

Is it a "strict" NACK, or just a "we have to wait until we merge back Bitcoin 0.17"?

frolosofsky commented 5 years ago

It's a "strict" NACK, or just a "we have to wait until we merge back Bitcoin 0.17"?

Yeah sure we will done cleanup of dead code after merging complete.

frolosofsky commented 5 years ago

Thanks for postponing this PR. Now it's good to go :)

frolosofsky commented 5 years ago

utACK 12205e13b7e1e1e8c358f3965b39b718698eb557

castarco commented 5 years ago

Closing it for now, it turns out that after merging in 0.17, some things became platform-specific and it's not as easy as before to check what's dead code and what's not.